Skip to content

fix: broken state for telemetryClientId, user agent versioning #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaynabors merged 1 commit into from
May 15, 2025
Merged

fix: broken state for telemetryClientId, user agent versioning #1850

chaynabors merged 1 commit into from
May 15, 2025

Conversation

@brandonskiser
Copy link
Contributor

@brandonskiser brandonskiser commented May 15, 2025 •
edited
Loading

Description of changes:

  • Adding the app version to the user agent.
  • Fixing an issue where state cannot be deserialized from the desktop app. This only happens for the telemetry client id currently, but we need to ensure that any state shared across chat and the desktop app does not get desync'd.

Before and after of the user agent:

Screenshot 2025-05-15 at 3 31 34 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.75%. Comparing base (c333c0f) to head (a7538e0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1850   +/-   ##
=======================================
  Coverage   16.75%   16.75%           
=======================================
  Files         213      213           
  Lines       20704    20704           
  Branches      871      871           
=======================================
  Hits         3468     3468           
  Misses      17236    17236

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandonskiser brandonskiser marked this pull request as ready for review May 15, 2025 22:32
@chaynabors chaynabors merged commit 10d90b3 into main May 15, 2025
21 checks passed
@chaynabors chaynabors deleted the bskiser/useragent branch May 15, 2025 22:33
This was referenced May 21, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaynabors chaynabors chaynabors approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brandonskiser @codecov-commenter @chaynabors